Attempt to mitigate locked machine.config #1825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antivirus occasionally opens machine.config for writing. If a .NET Framework app happens to launch during that brief window, it will create a popup with an error message and not continue until popup is closed. Since GVFS periodically runs maintenance tasks, it is not uncommon for users to find the error popup waiting for them first thing in the morning.
In addition, any GVFS C# app that makes HTTP requests will initialize ServicePointManager. This call can also fail if machine.config is locked (ie if the lock started after the app started so it didn't do the pop-up, or if the pop-up has been closed/skipped and the machine.config is still locked), and once it does it is unrecoverable.
This pull request attempts to mitigate the effects of machine.config locking in two ways: